Add Misssing Type Annotations#22
Merged
tekktrik merged 5 commits intoadafruit:mainfrom Sep 20, 2022
tcfranks:main
Merged
Conversation
tekktrik
requested changes
Sep 20, 2022
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
A few bits of feedback, thanks for the PR!
| def reference_temperature_thresholds(self, val): # pylint: disable=invalid-name | ||
| def reference_temperature_thresholds( # pylint: disable=invalid-name, | ||
| self, val: Tuple[float, float] | ||
| ) -> None: # pylint: disable=invalid-name |
Member
There was a problem hiding this comment.
Same thing here, I think it's this second # pylint: disable=invalid-name you can get rid of.
tekktrik
approved these changes
Sep 20, 2022
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
Awesome, thanks for another great PR!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 21, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3502 to 1.1.15 from 1.1.14: > Merge pull request adafruit/Adafruit_CircuitPython_DS3502#12 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.17 from 1.3.16: > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#27 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.1.18 from 2.1.17: > Merge pull request adafruit/Adafruit_CircuitPython_LIS2MDL#16 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31856 to 0.11.3 from 0.11.2: > Merge pull request adafruit/Adafruit_CircuitPython_MAX31856#22 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_BitbangIO to 1.3.9 from 1.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#24 from tcfranks/main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #15
submitted for review / comment